Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/deploy basic #46

Merged
merged 10 commits into from
Jan 14, 2024
Merged

Feat/deploy basic #46

merged 10 commits into from
Jan 14, 2024

Conversation

Phoenix500526
Copy link
Contributor

@Phoenix500526 Phoenix500526 commented Dec 21, 2023 •
edited
Loading

Please briefly answer these questions:
Implement the basic deploy logic. It's based on pr #45

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Implement the basic deploy logic

  • what changes does this pull request make?

  1. add XlineCluster CRD
  2. add some sync and reconcile logic
  3. add some unit tests and integration tests
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 mentioned this pull request Dec 21, 2023
Closed
LingKa28
LingKa28 previously approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@LingKa28 LingKa28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bsbds
bsbds reviewed Jan 8, 2024
View reviewed changes
api/v1alpha1/xlinecluster_types.go Outdated Show resolved Hide resolved
api/v1alpha1/xlinecluster_types.go Outdated Show resolved Hide resolved
config/rbac/role.yaml Show resolved Hide resolved
internal/controller/sharded.go Outdated Show resolved Hide resolved
iGxnon
iGxnon reviewed Jan 10, 2024
View reviewed changes
api/v1alpha1/xlinecluster_types.go Outdated Show resolved Hide resolved
internal/transformer/xlinecluster_resource.go Outdated Show resolved Hide resolved
bsbds
bsbds reviewed Jan 10, 2024
View reviewed changes
internal/reconciler/reconcile_context.go Outdated Show resolved Hide resolved
internal/reconciler/reconcile_test.go Outdated Show resolved Hide resolved
bsbds
bsbds previously approved these changes Jan 12, 2024
View reviewed changes
@Phoenix500526 Phoenix500526 merged commit a0c57b3 into xline-kv:main Jan 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsbds bsbds bsbds approved these changes

@iGxnon iGxnon iGxnon approved these changes

@LingKa28 LingKa28 LingKa28 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Phoenix500526 @iGxnon @bsbds @LingKa28